Add pointer to struct sigma_dut to get-ifname helper functions

This is needed to allow more dynamic generation of the interface name
for dual-radio cases.

Signed-off-by: Jouni Malinen <jouni@codeau

Add pointer to struct sigma_dut to get-ifname helper functions

This is needed to allow more dynamic generation of the interface name
for dual-radio cases.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

show more ...

Update command handler process() callback return value type

The partial move from returning int to returning enum sigma_cmd_result
was problematic for LLVM/Clang Control Flow Integrity (CFI) sanitiz

Update command handler process() callback return value type

The partial move from returning int to returning enum sigma_cmd_result
was problematic for LLVM/Clang Control Flow Integrity (CFI) sanitizer.
With CFI, the function pointers are verified to have the same type as
the actual callback function and enum is not considered to match int in
that context. This results in sigma_dut terminating if CFI is enabled
for the build. Avoid this by updating the process() callback functions
to use the exact same type as the function pointer.

This was done with following semantic patch and manual cleanup to remove
functions that matched but were not used as registered callbacks (those
functions can be addressed separately as cleanup since they do not cause
issues with CFI) and with coding style cleanup for indentation.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

show more ...

P2P: Set ctwindow before enabling opportunistic powersave

Set opportunistic power save parameters first and then enable
opportunistic power save so that opportunistic power save starts
with correct

P2P: Set ctwindow before enabling opportunistic powersave

Set opportunistic power save parameters first and then enable
opportunistic power save so that opportunistic power save starts
with correct parameters.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

show more ...

Add an option to replace iwpriv (WEXT) with cfg80211tool (nl80211)

Dynamically select whether to use iwpriv (WEXT) or cfg80211tool
(nl80211) for executing vendor extension commands. Change the iwpri

Add an option to replace iwpriv (WEXT) with cfg80211tool (nl80211)

Dynamically select whether to use iwpriv (WEXT) or cfg80211tool
(nl80211) for executing vendor extension commands. Change the iwpriv
commands corresponding to AP functionality to support cfg80211 command.
The run_iwpriv() function will use sigma_dut_print() in run_system() to
report failed commands in the debug log instead of having to do that in
all callers.

Signed-off-by: Priyadharshini Gowthaman <pgowtham@codeaurora.org>

show more ...

sta_wps_read_pin: Calculate a unique PIN for each station

One of the WPS tests requires each STA to have its own PIN. Calculate a
unique PIN for each station based on local MAC address instead of us

sta_wps_read_pin: Calculate a unique PIN for each station

One of the WPS tests requires each STA to have its own PIN. Calculate a
unique PIN for each station based on local MAC address instead of using
the same hardcoded PIN to meet this requirement.

Signed-off-by: Alexei Avshalom Lazar <ailizaro@codeaurora.org>

show more ...

Android: Also look for DHCP client in /vendor/bin

New Android flavors will have the DHCP client in /vendor/bin This commit
looks for these client programs in this partition, too.

Signed-off-by: Jou

Android: Also look for DHCP client in /vendor/bin

New Android flavors will have the DHCP client in /vendor/bin This commit
looks for these client programs in this partition, too.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

show more ...

sta_start_autonomous_go: Fix for 60G P2P test that start auto GO

In 60G P2P tests, the name of the P2P management interface may be
different from the data interface (for example, it can be called
p2

sta_start_autonomous_go: Fix for 60G P2P test that start auto GO

In 60G P2P tests, the name of the P2P management interface may be
different from the data interface (for example, it can be called
p2p-dev-wlan0). Make sure the correct interface name is used.

Signed-off-by: Alexei Avshalom Lazar <ailizaro@codeaurora.org>

show more ...

P2P: Fix off-by-one in p2p_group_get() buffer bounds checking

This buffer is a NUL terminated array so must check that the GO Device
Address is short enough to fit into the buffer with that extra ch

P2P: Fix off-by-one in p2p_group_get() buffer bounds checking

This buffer is a NUL terminated array so must check that the GO Device
Address is short enough to fit into the buffer with that extra character
added in the end.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

show more ...

Fix static analysis issues with strncpy()

Replace strncpy() with strlcpy() to silence static analysis warnings
about use of deprecated functions.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.co

Fix static analysis issues with strncpy()

Replace strncpy() with strlcpy() to silence static analysis warnings
about use of deprecated functions.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

show more ...

Fix length checks on inputs to ascii2hexstr() for WPS+NFC commands

The previously used checks were assuming incorrect direction for
hexdump/binary conversion and could have resulted in buffer write

Fix length checks on inputs to ascii2hexstr() for WPS+NFC commands

The previously used checks were assuming incorrect direction for
hexdump/binary conversion and could have resulted in buffer write
overflow with invalid input. The used buffers were long enough to avoid
issues with valid input of maximum SSID/passphrase length, i.e., this
does not show up in normal CAPI operations.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

show more ...

Add run_system_wrapper() which supports multi-variable arguments

This can reduce the lines of code as opposed to using run_system()
directly.

Signed-off-by: Adil Saeed Musthafa <adilm@qti.qualcomm.

Add run_system_wrapper() which supports multi-variable arguments

This can reduce the lines of code as opposed to using run_system()
directly.

Signed-off-by: Adil Saeed Musthafa <adilm@qti.qualcomm.com>

show more ...

Add Miracast R2 functionality along with R1

This provides an option to use an external library to execute Miracast
operations.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

Make couple of P2P helper functions non-static

This is needed for the Miracast implementation.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

P2P: Use 'type=progressive' while calling P2P_FIND to discover peer

The current behavior of P2P_FIND with no additional arguments will start
one full channel scan followed by only social channel sca

P2P: Use 'type=progressive' while calling P2P_FIND to discover peer

The current behavior of P2P_FIND with no additional arguments will start
one full channel scan followed by only social channel scans. If GO is
operating in not social channel and due to some reason the first full
channel scan is not able to discover GO, subsequent social channel scans
will fail to discover GO.

Adding 'type=progressive' while sending P2P_FIND will insure to scan one
non-social channel (different channel in each iteration) along with
social channels and eventually the GO will be discovered.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

show more ...

Trigger "P2P_SET ps 0" on the same interface during sta_p2p_reset()

During the p2p_reset, the "P2P_SET ps 0" command is sent on the station
interface and the corresponding command to enable the powe

Trigger "P2P_SET ps 0" on the same interface during sta_p2p_reset()

During the p2p_reset, the "P2P_SET ps 0" command is sent on the station
interface and the corresponding command to enable the power save
"P2P_SET ps 1" is sent on the respective interface (p2p). Thus, the
command to enable the power save does not reach to the driver, if the
power save state for the wdev interface (wdev->ps) in kernel is in
enabled state by default (CONFIG_CFG80211_DEFAULT_PS). This can be an
issue with drivers that do not have correctly synchronized power save
state with cfg80211 (cfg80211 assumes power save is enabled and tells
that to user space and drops requests to enable power save even though
the driver does not have power save enabled by default).

Work around this by also issuing "P2P_SET ps 0" on the same interface to
avoid need to fix the driver. The intention here is to not disturb the
existing implementation where this command is issued on the station
interface. This helps in not breaking the operability with the old host
drivers which expect this command on the station interface.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

show more ...

Validate 5 GHz channel in P2P commands

This commit fixes static analysis taint issues.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

Fix get_group_ifname() buffer use

If the group interface is fetched from the INTERFACES command, a pointer
to the local stack buffer was returned. This is not valid outside the
get_group_ifname() fu

Fix get_group_ifname() buffer use

If the group interface is fetched from the INTERFACES command, a pointer
to the local stack buffer was returned. This is not valid outside the
get_group_ifname() function, so use a static buffer to avoid such
issues.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

show more ...

Fix DHCP client starting for Android N

Use dhcptool as the DHCP client if dhcpcd is not available.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

Run DHCP internally on P2P Group Formation, if enabled [-g]

Try to run DHCP Client/Server on group formation. This option can only
be enabled while starting sigma_dut with "-g" option. If no such op

Run DHCP internally on P2P Group Formation, if enabled [-g]

Try to run DHCP Client/Server on group formation. This option can only
be enabled while starting sigma_dut with "-g" option. If no such option
is provided, external application need to start DHCP process(es).

A separate thread is started which keeps monitoring for
P2P-GROUP-STARTED and P2P-GROUP-REMOVED events and start DHCP
client/server based on P2P Client/GO role.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

show more ...

P2P: Disable UASPD sleep for 60 GHz program

UASPD sleep is not applicable for 60 GHz program. Change cmd_sta_sleep()
to return SIGMA_ERROR in this case.

Signed-off-by: Danny Segal <dsegal@qti.qualc

P2P: Disable UASPD sleep for 60 GHz program

UASPD sleep is not applicable for 60 GHz program. Change cmd_sta_sleep()
to return SIGMA_ERROR in this case.

Signed-off-by: Danny Segal <dsegal@qti.qualcomm.com>

show more ...

P2P: Avoid NoA setup in 60 GHz program

NoA is not applicable for 60 GHz. Skip NoA setup in P2P mode when
running 60 GHz test cases.

Signed-off-by: Danny Segal <dsegal@qti.qualcomm.com>

P2P: Fix listen channel for 60 GHz program

In the 60 GHz program, set the listen channel to be channel 2 in global
operating class 180.

Signed-off-by: Danny Segal <dsegal@qti.qualcomm.com>

P2P: Fix channel frequency calculations for 60 GHz channels

Signed-off-by: Danny Segal <dsegal@qti.qualcomm.com>

Use P2P virtual interface for P2P operations if needed

Implement support for virtual interface with P2P_DEVICE interface type.
This is used by wpa_supplicant for all P2P non-group operations
(discov

Use P2P virtual interface for P2P operations if needed

Implement support for virtual interface with P2P_DEVICE interface type.
This is used by wpa_supplicant for all P2P non-group operations
(discovery, GO negotiation, ..) with some drivers. It does not have an
associated netdev with it so it is simpler to implement. It is used to
separate scan and P2P search.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

show more ...

Import the initial version of sigma_dut open source project

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>