Miracast: Send a valid rtsp_session_id pointer

Earlier when zero is passed as pointer for rtsp_session_id, it was
causing a CFI failure and also a functional failure in hidl hal library.
Send a vali

Miracast: Send a valid rtsp_session_id pointer

Earlier when zero is passed as pointer for rtsp_session_id, it was
causing a CFI failure and also a functional failure in hidl hal library.
Send a valid pointer to rtsp_session_id parameter to
start_wfd_connection() in this exception to all other calls to avoid
this.

Signed-off-by: Vinita S. Maloo <vmaloo@codeaurora.org>

show more ...

Miracast: Avoid compiler warning about snprintf() truncating results

Explicitly check that the cmd buffer had sufficient room for the
command.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

Miracast: Modify the declaration for extn_sta_reset_default()

Modify the declaration of the function pointer extn_sta_reset_default to
match its implementation.

Signed-off-by: Jouni Malinen <jouni@

Miracast: Modify the declaration for extn_sta_reset_default()

Modify the declaration of the function pointer extn_sta_reset_default to
match its implementation.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

show more ...

Miracast: Get modified MAC address and then do the DHCP check

Enhance the capability of obtaining the modified MAC address and then
performing the DHCP check to detect whether the peer client has re

Miracast: Get modified MAC address and then do the DHCP check

Enhance the capability of obtaining the modified MAC address and then
performing the DHCP check to detect whether the peer client has received
an IP address rather than rely on MAC address parsing from the DHCP
lease file.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

show more ...

Miracast: Change data type of rtsp_session_id

Change the data type of rtsp_session_id from string to int to avoid
dealing with string lengths that would otherwise require being
propagated across the

Miracast: Change data type of rtsp_session_id

Change the data type of rtsp_session_id from string to int to avoid
dealing with string lengths that would otherwise require being
propagated across the code.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

show more ...

Miracast: Migrate to usage of native DHCP APIs

Use the native DHCP APIs by removing the MIRACAST_DHCP_M flag.
Remove legacy code for exercising DHCP functionality associated
with the flag.

Signed-o

Miracast: Migrate to usage of native DHCP APIs

Use the native DHCP APIs by removing the MIRACAST_DHCP_M flag.
Remove legacy code for exercising DHCP functionality associated
with the flag.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

show more ...

Use get_main_ifname() helper more consistently

This is needed to allow dut->main_ifname to point to multiple interface
names for dynamic selection with multi-radio setups.

Signed-off-by: Jouni Mali

Use get_main_ifname() helper more consistently

This is needed to allow dut->main_ifname to point to multiple interface
names for dynamic selection with multi-radio setups.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

show more ...

Move main_ifname/station_ifname into struct sigma_dut

Get rid of these global variables by moving them into struct sigma_dut.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

Add pointer to struct sigma_dut to get-ifname helper functions

This is needed to allow more dynamic generation of the interface name
for dual-radio cases.

Signed-off-by: Jouni Malinen <jouni@codeau

Add pointer to struct sigma_dut to get-ifname helper functions

This is needed to allow more dynamic generation of the interface name
for dual-radio cases.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

show more ...

Update command handler process() callback return value type

The partial move from returning int to returning enum sigma_cmd_result
was problematic for LLVM/Clang Control Flow Integrity (CFI) sanitiz

Update command handler process() callback return value type

The partial move from returning int to returning enum sigma_cmd_result
was problematic for LLVM/Clang Control Flow Integrity (CFI) sanitizer.
With CFI, the function pointers are verified to have the same type as
the actual callback function and enum is not considered to match int in
that context. This results in sigma_dut terminating if CFI is enabled
for the build. Avoid this by updating the process() callback functions
to use the exact same type as the function pointer.

This was done with following semantic patch and manual cleanup to remove
functions that matched but were not used as registered callbacks (those
functions can be addressed separately as cleanup since they do not cause
issues with CFI) and with coding style cleanup for indentation.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

show more ...

Miracast: Use the self generated PIN value with P2P_CONNECT display

Fix the sigma_dut controlled P2P group formation case where the local
device is displaying a PIN. The sigma_dut generated PIN is r

Miracast: Use the self generated PIN value with P2P_CONNECT display

Fix the sigma_dut controlled P2P group formation case where the local
device is displaying a PIN. The sigma_dut generated PIN is read by an
earlier CAPI command and it is send to the peer device. This same
previously generated PIN value needs to be sent from sigma_dut to
wpa_supplicant in the P2P_CONNECT command instead of requesting
wpa_supplicant to generate another PIN (which is what the "pin" argument
does). This fixed WPS PIN mismatch issues in related testing operations.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

show more ...

Update copyright notices for 2018

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

miracast: Check wpa_command_resp() return value in all cases

The response buffer may not be initialized if the function returns a
failure, so check for that explicitly.

Signed-off-by: Jouni Malinen

miracast: Check wpa_command_resp() return value in all cases

The response buffer may not be initialized if the function returns a
failure, so check for that explicitly.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

show more ...

miracast: Check return code before using returned buffer

In cmd_start_wfd_connection() and cmd_connect_go_start_wfd(), check
wpa_command_resp() result before using the returned buffer which could
be

miracast: Check return code before using returned buffer

In cmd_start_wfd_connection() and cmd_connect_go_start_wfd(), check
wpa_command_resp() result before using the returned buffer which could
be uninitialized in case of errors.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

show more ...

Miracast: Check FrameName argument in dev_send_frame handling

Reject dev_send_frame with missing FrameName argument to avoid potential
NULL pointer dereference.

Signed-off-by: Jouni Malinen <jouni@

Miracast: Check FrameName argument in dev_send_frame handling

Reject dev_send_frame with missing FrameName argument to avoid potential
NULL pointer dereference.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

show more ...

Miracast: Silence static analyzer warnings

Remove unnecessary checks for dut != NULL in thread entry functions to
keep pointer dereferences within those functions more consistent. dut
cannot be NULL

Miracast: Silence static analyzer warnings

Remove unnecessary checks for dut != NULL in thread entry functions to
keep pointer dereferences within those functions more consistent. dut
cannot be NULL in either of these cases.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

show more ...

Miracast: Fix for static analysis issue in connect_go_start_wfd()

sig_resp_buf() was not initialized at the time strlen(sig_resp_buf) was
used for the first time. There is no need to split this sig_

Miracast: Fix for static analysis issue in connect_go_start_wfd()

sig_resp_buf() was not initialized at the time strlen(sig_resp_buf) was
used for the first time. There is no need to split this sig_resp_buf
writing into two parts, so fix this by using a single snprintf() call.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

show more ...

Miracast: Fix return string for in start_wfd_connection

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

Fix static analysis issues with strncpy()

Replace strncpy() with strlcpy() to silence static analysis warnings
about use of deprecated functions.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.co

Fix static analysis issues with strncpy()

Replace strncpy() with strlcpy() to silence static analysis warnings
about use of deprecated functions.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

show more ...

Introduce shared strlcpy() and strlcat() implementations

These were already used internally in some source code files for
non-Android builds. Share a single common implementations in utils.c and
mak

Introduce shared strlcpy() and strlcat() implementations

These were already used internally in some source code files for
non-Android builds. Share a single common implementations in utils.c and
make it available throughout sigma_dut to make this cleaner.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

show more ...

Fix static analysis issues

Fix various static analysis issues.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

Miracast: Fix sta_generate_event

Fix sta_generate_event with Frame Skip parameter for Miracast R1.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

Miracast: Fix sta_get_parameter

Fix sta_get_parameter to return all discovered peers.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

Miracast: Add persistent group creation during Miracast session

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

Miracast: Fix error in command string generation

This fixes a logical error leading to generation of
incomplete command strings.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>