qcacld-3.0: Fix tdls vdev ref issue for race condition

When wpa_supplicant adds tdls peer during sta disconnecting,
scheduler thread clear MLO flag of vdev0, in wlan_key_get_link_vdev,
wlan_vdev_mlm

qcacld-3.0: Fix tdls vdev ref issue for race condition

When wpa_supplicant adds tdls peer during sta disconnecting,
scheduler thread clear MLO flag of vdev0, in wlan_key_get_link_vdev,
wlan_vdev_mlme_is_mlo_vdev(vdev0) return true, in
wlan_key_put_link_vdev, wlan_vdev_mlme_is_mlo_vdev(vdev0) return false,
WLAN_OSIF_TDLS_ID vdev ref count is released in both
wlan_key_get_link_vdev and wlan_key_put_link_vdev, while
WLAN_MLO_MGR_ID vdev ref count isn't released, assert will happen.

To fix it, add check in os_if, if vdev not up, reject tdls add peer to
avoid such race condition issue.

Change-Id: I851b269ee4a5649fe76cfa1fc6762b6ca41b0884
CRs-Fixed: 3598336

show more ...

qcacld-3.0: Fix tdls vdev ref issue for race condition

When wpa_supplicant sent tdls mgmt frame during sta disconnecting for NUD
failure, scheduler thread clear MLO flag of vdev0, in
wlan_key_get_li

qcacld-3.0: Fix tdls vdev ref issue for race condition

When wpa_supplicant sent tdls mgmt frame during sta disconnecting for NUD
failure, scheduler thread clear MLO flag of vdev0, in
wlan_key_get_link_vdev, wlan_vdev_mlme_is_mlo_vdev(vdev0) return true,
in wlan_key_put_link_vdev, wlan_vdev_mlme_is_mlo_vdev(vdev0) return false,
WLAN_OSIF_TDLS_ID vdev ref count is released in both
wlan_key_get_link_vdev and wlan_key_put_link_vdev, while WLAN_MLO_MGR_ID
vdev ref count isn't released, assert will happen.

To fix it, add check in os_if, if vdev not up, reject tdls frame to
avoid such race condition issue.

Change-Id: I90e60c95888cc63e57d0bd0b75c570d8d677cbaa
CRs-Fixed: 3572133

show more ...

qcacld-3.0: Init ret for wlan_cfg80211_tdls_mgmt_mlo

Currently ret is not initialized and it can return
uninitialized value in some cases.

Change-Id: Ic70ad295108cc89bea371b78f6f14ca356706d2b
CRs-F

qcacld-3.0: Init ret for wlan_cfg80211_tdls_mgmt_mlo

Currently ret is not initialized and it can return
uninitialized value in some cases.

Change-Id: Ic70ad295108cc89bea371b78f6f14ca356706d2b
CRs-Fixed: 3491253

show more ...

qcacld-3.0: Use backport flag to fill tdls params for 11be

To avoid compile issues where the kernel version doesn't support
11be and WLAN_FEATURE_11BE macro alone can't be used.
Use CFG80211_11BE_BA

qcacld-3.0: Use backport flag to fill tdls params for 11be

To avoid compile issues where the kernel version doesn't support
11be and WLAN_FEATURE_11BE macro alone can't be used.
Use CFG80211_11BE_BASIC to ensure proper kernel version check for
11be support.

Change-Id: I23a1b6f6e1b46a4ce686d8d1a4152c94922281fc
CRs-Fixed: 3482727

show more ...

qcacld-3.0: Use link_info pointer to get vdev from user

With single netdev multi vdev changes, each adapter now can
have multiple VDEVs. To get the right VDEV reference, callers
have to pass the lin

qcacld-3.0: Use link_info pointer to get vdev from user

With single netdev multi vdev changes, each adapter now can
have multiple VDEVs. To get the right VDEV reference, callers
have to pass the link info corresponding to that VDEV.

Change hdd_objmgr_get_vdev_by_user() API definition to
fetch lock protected VDEV reference from link info
instead of adapter.
The existing callers moved to deflink in adapter.

Change-Id: I3be810994f8768104c9a93491966a13d3b159e5c
CRs-Fixed: 3448468

show more ...

qcacld-3.0: Resolve compile issue for Fillmore

Add macro check about CFG80211_LINK_STA_PARAMS_PRESENT for
function wlan_cfg80211_tdls_extract_eht_params.

Change-Id: I1982d97f06e333936ea45828f5082d3

qcacld-3.0: Resolve compile issue for Fillmore

Add macro check about CFG80211_LINK_STA_PARAMS_PRESENT for
function wlan_cfg80211_tdls_extract_eht_params.

Change-Id: I1982d97f06e333936ea45828f5082d322664a2c0
CRs-Fixed: 3479244

show more ...

qcacld-3.0: Release vdev ref count for TDLS

The vdev ref count does not release properly for
WLAN_OSIF_TDLS_ID, it causes driver crash when
rmmod wifi module.

To address this issue, release the vde

qcacld-3.0: Release vdev ref count for TDLS

The vdev ref count does not release properly for
WLAN_OSIF_TDLS_ID, it causes driver crash when
rmmod wifi module.

To address this issue, release the vdev ref count
properly for TDLS module.

Change-Id: I9c206f212ff5ba5a362c91d32519bc7903cbec3d
CRs-Fixed: 3470275

show more ...

qcacld-3.0: Add logic to support tdls on MLO

Since for MLD device, it can only choice one link for tdls,
add logic like this:
1\ As initiator, it needs to send discovery request on each
link, before

qcacld-3.0: Add logic to support tdls on MLO

Since for MLD device, it can only choice one link for tdls,
add logic like this:
1\ As initiator, it needs to send discovery request on each
link, before send the frame, it needs to force active the link;
2\ As responder, it sends the discovery response the link id,
before send the frame, it needs to force active the link;
3\ For other tdls management and tdls operation, it needs to
find out which link(vdev) is used as tdls link first.

Change-Id: I64e27219eb6c6b3fef62e541423aa8e5d84b1560
CRs-Fixed: 3439568

show more ...

qcacld-3.0: Set eht_capable accordingly for TDLS

Set parameter add_sta_params->eht_capable accordingly whether
the peer STA support it or not.

Change-Id: Ib3664be74ece59804321e187fea889610c0a2a86
C

qcacld-3.0: Set eht_capable accordingly for TDLS

Set parameter add_sta_params->eht_capable accordingly whether
the peer STA support it or not.

Change-Id: Ib3664be74ece59804321e187fea889610c0a2a86
CRs-Fixed: 3454661

show more ...

qcacld-3.0: Add link id to tdls kernel API

Add link id param to tdls send mgmt and oper request
of kernel API.

Change-Id: I05bd2243ca00c3273b2e99c728940421d0399577
CRs-Fixed: 3439354

qcacld-3.0: Remove TDLS_MAX_NO_OF_2_4_CHANNELS

Use of the macro TDLS_MAX_NO_OF_2_4_CHANNELS was removed by the
following patch:
qcacld-3.0: Process rx_mgmt_pkt based on frequency
Change-Id Ib063

qcacld-3.0: Remove TDLS_MAX_NO_OF_2_4_CHANNELS

Use of the macro TDLS_MAX_NO_OF_2_4_CHANNELS was removed by the
following patch:
qcacld-3.0: Process rx_mgmt_pkt based on frequency
Change-Id Ib063070738ecdb4f83379eafe50629778a490aae

But the macro itself was not removed, so remove it now.

Change-Id: Iae040652e46795add803056bfe63c18de4dfeaf1
CRs-Fixed: 3426257

show more ...

qcacld-3.0: Fix wlan_cfg80211_tdls.h documentation

wlan_cfg80211_tdls.h has a few documentation issues, so fix them.

Change-Id: I60533048f1a3a1eff03f597b34b193ba1d292c96
CRs-Fixed: 3324161

qcacld-3.0: Fix new misspellings in wlan_cfg80211_tdls.c

The following change introduced new misspellings into
wlan_cfg80211_tdls.c, so fix them.
- Change-Id I3a1a05961bb5e747d946ffa8314319f898ef7b9

qcacld-3.0: Fix new misspellings in wlan_cfg80211_tdls.c

The following change introduced new misspellings into
wlan_cfg80211_tdls.c, so fix them.
- Change-Id I3a1a05961bb5e747d946ffa8314319f898ef7b97
qcacld-3.0: Link params embedded in station param struct

Change-Id: Idf4f214f5e9e4656b241f8de015fc49d64fc4852
CRs-Fixed: 3319365

show more ...

qcacld-3.0: Link params embedded in station param struct

In kernel 5.15 and above a new member is introduced in
station_parameters structure to move link specific variables.

This change will port t

qcacld-3.0: Link params embedded in station param struct

In kernel 5.15 and above a new member is introduced in
station_parameters structure to move link specific variables.

This change will port the driver code to make it compatible.

Change-Id: I3a1a05961bb5e747d946ffa8314319f898ef7b97
CRs-Fixed: 3304240

show more ...

qcacld-3.0: os_if: Fix misspellings

Fix misspellings in os_if/...

Change-Id: I040d4344f0065b1045e5ac7037c70123ca4231ef
CRs-Fixed: 3303622

qcacld-3.0: Inform frame via assoc link net device even in other interface

As per single netdev design, if the frame is received on the
on link vdev then retrieve assoc link net device and use that

qcacld-3.0: Inform frame via assoc link net device even in other interface

As per single netdev design, if the frame is received on the
on link vdev then retrieve assoc link net device and use that
to send the frame to userspace.

Change-Id: I85b2f7363cfb237877ca945c9b627f2bf89d0f54
CRs-Fixed: 3272194

show more ...

qcacld-3.0: Correct the method to parse TDLS supported channels

It reads supported channels incorrect and cause setup TDLS link off
channel failed. This change uses correct method to parse TDLS supp

qcacld-3.0: Correct the method to parse TDLS supported channels

It reads supported channels incorrect and cause setup TDLS link off
channel failed. This change uses correct method to parse TDLS supported
channels.

Change-Id: I0c605497df1c50aadc276634f641aa6c37c6932a
CRs-Fixed: 3265112

show more ...

qcacld-3.0: Use freq to process Tdls peer supported chans

With introduction of TDLS on 6 GHz, some of the channels
that peer can support will be same for 6 GHz band other
bands. So, extract frequenc

qcacld-3.0: Use freq to process Tdls peer supported chans

With introduction of TDLS on 6 GHz, some of the channels
that peer can support will be same for 6 GHz band other
bands. So, extract frequency by using peer supported
operating class and supported channel list which can
be used for further processing.
If channel numbers are used then the duplicate channel
numbers are removed which may lead to skipping 6 GHz
supported channels.

Change-Id: Ic6838d05c3dab5a0cc17483890b83805e076684c
CRs-Fixed: 3233999

show more ...

qcacld-3.0: Allow TDLS connection in wideband only if fw supports

Irrespective of 6 GHz, wideband can be supported.
So, Allow TDLS connection in wideband only if FW supports TDLS
on 6Ghz.
If Fw does

qcacld-3.0: Allow TDLS connection in wideband only if fw supports

Irrespective of 6 GHz, wideband can be supported.
So, Allow TDLS connection in wideband only if FW supports TDLS
on 6Ghz.
If Fw doesn't support wideband then restrict the TDLS connection
BW to APs Bw.

Change-Id: If726233f381921a8eda25ac7a2705942db79d410
CRs-Fixed: 3223760

show more ...

qcacld-3.0: Allow TDLS connection on 6GHz only if fw supports

Allow TDLS connection on 6GHz only if FW supports TDLS on 6GHz.

Change-Id: I663bd6d73235664c21029d8956f465da5a5b39c6
CRs-Fixed: 3223677

qcacld-3.0: tdls: Replace fallthrough comment with attribute

-Wimplicit-fallthrough is being enabled by default. Some compilers
such as clang require the attribute instead of just a fallthrough comm

qcacld-3.0: tdls: Replace fallthrough comment with attribute

-Wimplicit-fallthrough is being enabled by default. Some compilers
such as clang require the attribute instead of just a fallthrough comment.

Change-Id: Icdb1590b51cf172728c3b484f05d20c49e68c38e
CRs-Fixed: 3217422

show more ...

qcacld-3.0: Correct the condition to reject TDLS

Reject any incoming get_all_peers TDLS command if there
are any currently in progress.
The later commands will only be processed once the earlier
com

qcacld-3.0: Correct the condition to reject TDLS

Reject any incoming get_all_peers TDLS command if there
are any currently in progress.
The later commands will only be processed once the earlier
commands finish, since they are processed sequentially.
However, once a command finishes, the memory allocated for
it from userspace is freed up. Each command is passed the
same address so the later commands will end up writing to
a freed address. To avoid this, reject incoming requests
if there are any still in progress.
For this, the condition should be corrected.
We shouldn't use completion_done here for checking for
completion as this will always return false, as
tdls_user_cmd_comp.done will remain in init state always.
So, the very first command will also not work.
In general completion_done is used to check if there are
multiple threads waiting on the complete event that's
why it will return true only when tdls_user_cmd_comp.done
is set with complete().
Also, if the state is in wait_for_completion, this function
will return true after the wait timer is over or condition
is met as wait_for_completion will hold out the hold lock
and will will prevent completion_done from returning.
Better to use a flag to determine command condition.

Change-Id: I1b6b270dbb9b0b103f10e7ae22a60030ea2fbb98
CRs-Fixed: 3162184

show more ...

qcacld-3.0: Reject TDLS cmd if still in progress

Reject any incoming get_all_peers TDLS command if there are any
currently in progress.

The later commands will only be processed once the earlier co

qcacld-3.0: Reject TDLS cmd if still in progress

Reject any incoming get_all_peers TDLS command if there are any
currently in progress.

The later commands will only be processed once the earlier commands
finish, since they are processed sequentially. However, once a
command finishes, the memory allocated for it from userspace is freed
up. Each command is passed the same address so the later commands will
end up writing to a freed address. To avoid this, reject incoming
requests if there are any still in progress.

Change-Id: I6970e3b73c6ce5afc921edaaf477825928800342
CRs-Fixed: 3150044

show more ...