1 // SPDX-License-Identifier: GPL-2.0 OR MIT
2 /**************************************************************************
3 *
4 * Copyright (c) 2009-2024 Broadcom. All Rights Reserved. The term
5 * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.
6 *
7 * Permission is hereby granted, free of charge, to any person obtaining a
8 * copy of this software and associated documentation files (the
9 * "Software"), to deal in the Software without restriction, including
10 * without limitation the rights to use, copy, modify, merge, publish,
11 * distribute, sub license, and/or sell copies of the Software, and to
12 * permit persons to whom the Software is furnished to do so, subject to
13 * the following conditions:
14 *
15 * The above copyright notice and this permission notice (including the
16 * next paragraph) shall be included in all copies or substantial portions
17 * of the Software.
18 *
19 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
20 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
21 * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL
22 * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM,
23 * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
24 * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
25 * USE OR OTHER DEALINGS IN THE SOFTWARE.
26 *
27 **************************************************************************/
28
29 #include "vmwgfx_bo.h"
30 #include "vmwgfx_kms.h"
31 #include "vmwgfx_vkms.h"
32
33 #include <drm/drm_atomic.h>
34 #include <drm/drm_atomic_helper.h>
35 #include <drm/drm_fourcc.h>
36
37
38 #define vmw_crtc_to_ldu(x) \
39 container_of(x, struct vmw_legacy_display_unit, base.crtc)
40 #define vmw_encoder_to_ldu(x) \
41 container_of(x, struct vmw_legacy_display_unit, base.encoder)
42 #define vmw_connector_to_ldu(x) \
43 container_of(x, struct vmw_legacy_display_unit, base.connector)
44
45 struct vmw_legacy_display {
46 struct list_head active;
47
48 unsigned num_active;
49 unsigned last_num_active;
50
51 struct vmw_framebuffer *fb;
52 };
53
54 /*
55 * Display unit using the legacy register interface.
56 */
57 struct vmw_legacy_display_unit {
58 struct vmw_display_unit base;
59
60 struct list_head active;
61 };
62
vmw_ldu_destroy(struct vmw_legacy_display_unit * ldu)63 static void vmw_ldu_destroy(struct vmw_legacy_display_unit *ldu)
64 {
65 list_del_init(&ldu->active);
66 vmw_du_cleanup(&ldu->base);
67 kfree(ldu);
68 }
69
70
71 /*
72 * Legacy Display Unit CRTC functions
73 */
74
vmw_ldu_crtc_destroy(struct drm_crtc * crtc)75 static void vmw_ldu_crtc_destroy(struct drm_crtc *crtc)
76 {
77 vmw_ldu_destroy(vmw_crtc_to_ldu(crtc));
78 }
79
vmw_ldu_commit_list(struct vmw_private * dev_priv)80 static int vmw_ldu_commit_list(struct vmw_private *dev_priv)
81 {
82 struct vmw_legacy_display *lds = dev_priv->ldu_priv;
83 struct vmw_legacy_display_unit *entry;
84 struct drm_framebuffer *fb = NULL;
85 struct drm_crtc *crtc = NULL;
86 int i;
87
88 /* If there is no display topology the host just assumes
89 * that the guest will set the same layout as the host.
90 */
91 if (!(dev_priv->capabilities & SVGA_CAP_DISPLAY_TOPOLOGY)) {
92 int w = 0, h = 0;
93 list_for_each_entry(entry, &lds->active, active) {
94 crtc = &entry->base.crtc;
95 w = max(w, crtc->x + crtc->mode.hdisplay);
96 h = max(h, crtc->y + crtc->mode.vdisplay);
97 }
98
99 if (crtc == NULL)
100 return 0;
101 fb = crtc->primary->state->fb;
102
103 return vmw_kms_write_svga(dev_priv, w, h, fb->pitches[0],
104 fb->format->cpp[0] * 8,
105 fb->format->depth);
106 }
107
108 if (!list_empty(&lds->active)) {
109 entry = list_entry(lds->active.next, typeof(*entry), active);
110 fb = entry->base.crtc.primary->state->fb;
111
112 vmw_kms_write_svga(dev_priv, fb->width, fb->height, fb->pitches[0],
113 fb->format->cpp[0] * 8, fb->format->depth);
114 }
115
116 /* Make sure we always show something. */
117 vmw_write(dev_priv, SVGA_REG_NUM_GUEST_DISPLAYS,
118 lds->num_active ? lds->num_active : 1);
119
120 i = 0;
121 list_for_each_entry(entry, &lds->active, active) {
122 crtc = &entry->base.crtc;
123
124 vmw_write(dev_priv, SVGA_REG_DISPLAY_ID, i);
125 vmw_write(dev_priv, SVGA_REG_DISPLAY_IS_PRIMARY, !i);
126 vmw_write(dev_priv, SVGA_REG_DISPLAY_POSITION_X, crtc->x);
127 vmw_write(dev_priv, SVGA_REG_DISPLAY_POSITION_Y, crtc->y);
128 vmw_write(dev_priv, SVGA_REG_DISPLAY_WIDTH, crtc->mode.hdisplay);
129 vmw_write(dev_priv, SVGA_REG_DISPLAY_HEIGHT, crtc->mode.vdisplay);
130
131 i++;
132 }
133
134 BUG_ON(i != lds->num_active);
135
136 lds->last_num_active = lds->num_active;
137
138 return 0;
139 }
140
141 /*
142 * Pin the buffer in a location suitable for access by the
143 * display system.
144 */
vmw_ldu_fb_pin(struct vmw_framebuffer * vfb)145 static int vmw_ldu_fb_pin(struct vmw_framebuffer *vfb)
146 {
147 struct vmw_private *dev_priv = vmw_priv(vfb->base.dev);
148 struct vmw_bo *buf;
149 int ret;
150
151 buf = vfb->bo ?
152 vmw_framebuffer_to_vfbd(&vfb->base)->buffer :
153 vmw_user_object_buffer(&vmw_framebuffer_to_vfbs(&vfb->base)->uo);
154
155 if (!buf)
156 return 0;
157 WARN_ON(dev_priv->active_display_unit != vmw_du_legacy);
158
159 if (dev_priv->active_display_unit == vmw_du_legacy) {
160 vmw_overlay_pause_all(dev_priv);
161 ret = vmw_bo_pin_in_start_of_vram(dev_priv, buf, false);
162 vmw_overlay_resume_all(dev_priv);
163 } else
164 ret = -EINVAL;
165
166 return ret;
167 }
168
vmw_ldu_fb_unpin(struct vmw_framebuffer * vfb)169 static int vmw_ldu_fb_unpin(struct vmw_framebuffer *vfb)
170 {
171 struct vmw_private *dev_priv = vmw_priv(vfb->base.dev);
172 struct vmw_bo *buf;
173
174 buf = vfb->bo ?
175 vmw_framebuffer_to_vfbd(&vfb->base)->buffer :
176 vmw_user_object_buffer(&vmw_framebuffer_to_vfbs(&vfb->base)->uo);
177
178
179 if (WARN_ON(!buf))
180 return 0;
181
182 return vmw_bo_unpin(dev_priv, buf, false);
183 }
184
vmw_ldu_del_active(struct vmw_private * vmw_priv,struct vmw_legacy_display_unit * ldu)185 static int vmw_ldu_del_active(struct vmw_private *vmw_priv,
186 struct vmw_legacy_display_unit *ldu)
187 {
188 struct vmw_legacy_display *ld = vmw_priv->ldu_priv;
189 if (list_empty(&ldu->active))
190 return 0;
191
192 /* Must init otherwise list_empty(&ldu->active) will not work. */
193 list_del_init(&ldu->active);
194 if (--(ld->num_active) == 0) {
195 BUG_ON(!ld->fb);
196 WARN_ON(vmw_ldu_fb_unpin(ld->fb));
197 ld->fb = NULL;
198 }
199
200 return 0;
201 }
202
vmw_ldu_add_active(struct vmw_private * vmw_priv,struct vmw_legacy_display_unit * ldu,struct vmw_framebuffer * vfb)203 static int vmw_ldu_add_active(struct vmw_private *vmw_priv,
204 struct vmw_legacy_display_unit *ldu,
205 struct vmw_framebuffer *vfb)
206 {
207 struct vmw_legacy_display *ld = vmw_priv->ldu_priv;
208 struct vmw_legacy_display_unit *entry;
209 struct list_head *at;
210
211 BUG_ON(!ld->num_active && ld->fb);
212 if (vfb != ld->fb) {
213 if (ld->fb)
214 WARN_ON(vmw_ldu_fb_unpin(ld->fb));
215 vmw_svga_enable(vmw_priv);
216 WARN_ON(vmw_ldu_fb_pin(vfb));
217 ld->fb = vfb;
218 }
219
220 if (!list_empty(&ldu->active))
221 return 0;
222
223 at = &ld->active;
224 list_for_each_entry(entry, &ld->active, active) {
225 if (entry->base.unit > ldu->base.unit)
226 break;
227
228 at = &entry->active;
229 }
230
231 list_add(&ldu->active, at);
232
233 ld->num_active++;
234
235 return 0;
236 }
237
238 /**
239 * vmw_ldu_crtc_mode_set_nofb - Enable svga
240 *
241 * @crtc: CRTC associated with the new screen
242 *
243 * For LDU, just enable the svga
244 */
vmw_ldu_crtc_mode_set_nofb(struct drm_crtc * crtc)245 static void vmw_ldu_crtc_mode_set_nofb(struct drm_crtc *crtc)
246 {
247 }
248
249 static const struct drm_crtc_funcs vmw_legacy_crtc_funcs = {
250 .gamma_set = vmw_du_crtc_gamma_set,
251 .destroy = vmw_ldu_crtc_destroy,
252 .reset = vmw_du_crtc_reset,
253 .atomic_duplicate_state = vmw_du_crtc_duplicate_state,
254 .atomic_destroy_state = vmw_du_crtc_destroy_state,
255 .set_config = drm_atomic_helper_set_config,
256 .page_flip = drm_atomic_helper_page_flip,
257 .enable_vblank = vmw_vkms_enable_vblank,
258 .disable_vblank = vmw_vkms_disable_vblank,
259 .get_vblank_timestamp = vmw_vkms_get_vblank_timestamp,
260 };
261
262
263 /*
264 * Legacy Display Unit encoder functions
265 */
266
vmw_ldu_encoder_destroy(struct drm_encoder * encoder)267 static void vmw_ldu_encoder_destroy(struct drm_encoder *encoder)
268 {
269 vmw_ldu_destroy(vmw_encoder_to_ldu(encoder));
270 }
271
272 static const struct drm_encoder_funcs vmw_legacy_encoder_funcs = {
273 .destroy = vmw_ldu_encoder_destroy,
274 };
275
276 /*
277 * Legacy Display Unit connector functions
278 */
279
vmw_ldu_connector_destroy(struct drm_connector * connector)280 static void vmw_ldu_connector_destroy(struct drm_connector *connector)
281 {
282 vmw_ldu_destroy(vmw_connector_to_ldu(connector));
283 }
284
285 static const struct drm_connector_funcs vmw_legacy_connector_funcs = {
286 .dpms = vmw_du_connector_dpms,
287 .detect = vmw_du_connector_detect,
288 .fill_modes = drm_helper_probe_single_connector_modes,
289 .destroy = vmw_ldu_connector_destroy,
290 .reset = vmw_du_connector_reset,
291 .atomic_duplicate_state = vmw_du_connector_duplicate_state,
292 .atomic_destroy_state = vmw_du_connector_destroy_state,
293 };
294
295 static const struct
296 drm_connector_helper_funcs vmw_ldu_connector_helper_funcs = {
297 .get_modes = vmw_connector_get_modes,
298 .mode_valid = vmw_connector_mode_valid
299 };
300
301 static int vmw_kms_ldu_do_bo_dirty(struct vmw_private *dev_priv,
302 struct vmw_framebuffer *framebuffer,
303 unsigned int flags, unsigned int color,
304 struct drm_mode_rect *clips,
305 unsigned int num_clips);
306
307 /*
308 * Legacy Display Plane Functions
309 */
310
311 static void
vmw_ldu_primary_plane_atomic_update(struct drm_plane * plane,struct drm_atomic_state * state)312 vmw_ldu_primary_plane_atomic_update(struct drm_plane *plane,
313 struct drm_atomic_state *state)
314 {
315 struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
316 plane);
317 struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state,
318 plane);
319 struct vmw_private *dev_priv;
320 struct vmw_legacy_display_unit *ldu;
321 struct vmw_framebuffer *vfb;
322 struct drm_framebuffer *fb;
323 struct drm_crtc *crtc = new_state->crtc ?: old_state->crtc;
324
325 ldu = vmw_crtc_to_ldu(crtc);
326 dev_priv = vmw_priv(plane->dev);
327 fb = new_state->fb;
328
329 vfb = (fb) ? vmw_framebuffer_to_vfb(fb) : NULL;
330
331 if (vfb)
332 vmw_ldu_add_active(dev_priv, ldu, vfb);
333 else
334 vmw_ldu_del_active(dev_priv, ldu);
335
336 vmw_ldu_commit_list(dev_priv);
337
338 if (vfb && vmw_cmd_supported(dev_priv)) {
339 struct drm_mode_rect fb_rect = {
340 .x1 = 0,
341 .y1 = 0,
342 .x2 = vfb->base.width,
343 .y2 = vfb->base.height
344 };
345 struct drm_mode_rect *damage_rects = drm_plane_get_damage_clips(new_state);
346 u32 rect_count = drm_plane_get_damage_clips_count(new_state);
347 int ret;
348
349 if (!damage_rects) {
350 damage_rects = &fb_rect;
351 rect_count = 1;
352 }
353
354 ret = vmw_kms_ldu_do_bo_dirty(dev_priv, vfb, 0, 0, damage_rects, rect_count);
355
356 drm_WARN_ONCE(plane->dev, ret,
357 "vmw_kms_ldu_do_bo_dirty failed with: ret=%d\n", ret);
358
359 vmw_cmd_flush(dev_priv, false);
360 }
361 }
362
363 static const struct drm_plane_funcs vmw_ldu_plane_funcs = {
364 .update_plane = drm_atomic_helper_update_plane,
365 .disable_plane = drm_atomic_helper_disable_plane,
366 .destroy = vmw_du_primary_plane_destroy,
367 .reset = vmw_du_plane_reset,
368 .atomic_duplicate_state = vmw_du_plane_duplicate_state,
369 .atomic_destroy_state = vmw_du_plane_destroy_state,
370 };
371
372 static const struct drm_plane_funcs vmw_ldu_cursor_funcs = {
373 .update_plane = drm_atomic_helper_update_plane,
374 .disable_plane = drm_atomic_helper_disable_plane,
375 .destroy = vmw_du_cursor_plane_destroy,
376 .reset = vmw_du_plane_reset,
377 .atomic_duplicate_state = vmw_du_plane_duplicate_state,
378 .atomic_destroy_state = vmw_du_plane_destroy_state,
379 };
380
381 /*
382 * Atomic Helpers
383 */
384 static const struct
385 drm_plane_helper_funcs vmw_ldu_cursor_plane_helper_funcs = {
386 .atomic_check = vmw_du_cursor_plane_atomic_check,
387 .atomic_update = vmw_du_cursor_plane_atomic_update,
388 .prepare_fb = vmw_du_cursor_plane_prepare_fb,
389 .cleanup_fb = vmw_du_cursor_plane_cleanup_fb,
390 };
391
392 static const struct
393 drm_plane_helper_funcs vmw_ldu_primary_plane_helper_funcs = {
394 .atomic_check = vmw_du_primary_plane_atomic_check,
395 .atomic_update = vmw_ldu_primary_plane_atomic_update,
396 };
397
398 static const struct drm_crtc_helper_funcs vmw_ldu_crtc_helper_funcs = {
399 .mode_set_nofb = vmw_ldu_crtc_mode_set_nofb,
400 .atomic_check = vmw_du_crtc_atomic_check,
401 .atomic_begin = vmw_du_crtc_atomic_begin,
402 .atomic_flush = vmw_vkms_crtc_atomic_flush,
403 .atomic_enable = vmw_vkms_crtc_atomic_enable,
404 .atomic_disable = vmw_vkms_crtc_atomic_disable,
405 };
406
407
vmw_ldu_init(struct vmw_private * dev_priv,unsigned unit)408 static int vmw_ldu_init(struct vmw_private *dev_priv, unsigned unit)
409 {
410 struct vmw_legacy_display_unit *ldu;
411 struct drm_device *dev = &dev_priv->drm;
412 struct drm_connector *connector;
413 struct drm_encoder *encoder;
414 struct drm_plane *primary;
415 struct vmw_cursor_plane *cursor;
416 struct drm_crtc *crtc;
417 int ret;
418
419 ldu = kzalloc(sizeof(*ldu), GFP_KERNEL);
420 if (!ldu)
421 return -ENOMEM;
422
423 ldu->base.unit = unit;
424 crtc = &ldu->base.crtc;
425 encoder = &ldu->base.encoder;
426 connector = &ldu->base.connector;
427 primary = &ldu->base.primary;
428 cursor = &ldu->base.cursor;
429
430 INIT_LIST_HEAD(&ldu->active);
431
432 ldu->base.pref_active = (unit == 0);
433 ldu->base.pref_width = dev_priv->initial_width;
434 ldu->base.pref_height = dev_priv->initial_height;
435
436 /*
437 * Remove this after enabling atomic because property values can
438 * only exist in a state object
439 */
440 ldu->base.is_implicit = true;
441
442 /* Initialize primary plane */
443 ret = drm_universal_plane_init(dev, primary,
444 0, &vmw_ldu_plane_funcs,
445 vmw_primary_plane_formats,
446 ARRAY_SIZE(vmw_primary_plane_formats),
447 NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
448 if (ret) {
449 DRM_ERROR("Failed to initialize primary plane");
450 goto err_free;
451 }
452
453 drm_plane_helper_add(primary, &vmw_ldu_primary_plane_helper_funcs);
454
455 /*
456 * We're going to be using traces and software cursors
457 */
458 if (vmw_cmd_supported(dev_priv)) {
459 /* Initialize cursor plane */
460 ret = drm_universal_plane_init(dev, &cursor->base,
461 0, &vmw_ldu_cursor_funcs,
462 vmw_cursor_plane_formats,
463 ARRAY_SIZE(vmw_cursor_plane_formats),
464 NULL, DRM_PLANE_TYPE_CURSOR, NULL);
465 if (ret) {
466 DRM_ERROR("Failed to initialize cursor plane");
467 drm_plane_cleanup(&ldu->base.primary);
468 goto err_free;
469 }
470
471 drm_plane_helper_add(&cursor->base, &vmw_ldu_cursor_plane_helper_funcs);
472 }
473
474 ret = drm_connector_init(dev, connector, &vmw_legacy_connector_funcs,
475 DRM_MODE_CONNECTOR_VIRTUAL);
476 if (ret) {
477 DRM_ERROR("Failed to initialize connector\n");
478 goto err_free;
479 }
480
481 drm_connector_helper_add(connector, &vmw_ldu_connector_helper_funcs);
482 connector->status = vmw_du_connector_detect(connector, true);
483
484 ret = drm_encoder_init(dev, encoder, &vmw_legacy_encoder_funcs,
485 DRM_MODE_ENCODER_VIRTUAL, NULL);
486 if (ret) {
487 DRM_ERROR("Failed to initialize encoder\n");
488 goto err_free_connector;
489 }
490
491 (void) drm_connector_attach_encoder(connector, encoder);
492 encoder->possible_crtcs = (1 << unit);
493 encoder->possible_clones = 0;
494
495 ret = drm_connector_register(connector);
496 if (ret) {
497 DRM_ERROR("Failed to register connector\n");
498 goto err_free_encoder;
499 }
500
501 ret = drm_crtc_init_with_planes(dev, crtc, primary,
502 vmw_cmd_supported(dev_priv) ? &cursor->base : NULL,
503 &vmw_legacy_crtc_funcs, NULL);
504 if (ret) {
505 DRM_ERROR("Failed to initialize CRTC\n");
506 goto err_free_unregister;
507 }
508
509 drm_crtc_helper_add(crtc, &vmw_ldu_crtc_helper_funcs);
510
511 drm_mode_crtc_set_gamma_size(crtc, 256);
512
513 drm_object_attach_property(&connector->base,
514 dev_priv->hotplug_mode_update_property, 1);
515 drm_object_attach_property(&connector->base,
516 dev->mode_config.suggested_x_property, 0);
517 drm_object_attach_property(&connector->base,
518 dev->mode_config.suggested_y_property, 0);
519 if (dev_priv->implicit_placement_property)
520 drm_object_attach_property
521 (&connector->base,
522 dev_priv->implicit_placement_property,
523 1);
524
525 vmw_du_init(&ldu->base);
526
527 return 0;
528
529 err_free_unregister:
530 drm_connector_unregister(connector);
531 err_free_encoder:
532 drm_encoder_cleanup(encoder);
533 err_free_connector:
534 drm_connector_cleanup(connector);
535 err_free:
536 kfree(ldu);
537 return ret;
538 }
539
vmw_kms_ldu_init_display(struct vmw_private * dev_priv)540 int vmw_kms_ldu_init_display(struct vmw_private *dev_priv)
541 {
542 struct drm_device *dev = &dev_priv->drm;
543 int i, ret;
544 int num_display_units = (dev_priv->capabilities & SVGA_CAP_MULTIMON) ?
545 VMWGFX_NUM_DISPLAY_UNITS : 1;
546
547 if (unlikely(dev_priv->ldu_priv)) {
548 return -EINVAL;
549 }
550
551 dev_priv->ldu_priv = kmalloc(sizeof(*dev_priv->ldu_priv), GFP_KERNEL);
552 if (!dev_priv->ldu_priv)
553 return -ENOMEM;
554
555 INIT_LIST_HEAD(&dev_priv->ldu_priv->active);
556 dev_priv->ldu_priv->num_active = 0;
557 dev_priv->ldu_priv->last_num_active = 0;
558 dev_priv->ldu_priv->fb = NULL;
559
560 vmw_kms_create_implicit_placement_property(dev_priv);
561
562 for (i = 0; i < num_display_units; ++i) {
563 ret = vmw_ldu_init(dev_priv, i);
564 if (ret != 0)
565 goto err_free;
566 }
567
568 dev_priv->active_display_unit = vmw_du_legacy;
569
570 drm_mode_config_reset(dev);
571
572 return 0;
573
574 err_free:
575 kfree(dev_priv->ldu_priv);
576 dev_priv->ldu_priv = NULL;
577 return ret;
578 }
579
vmw_kms_ldu_close_display(struct vmw_private * dev_priv)580 int vmw_kms_ldu_close_display(struct vmw_private *dev_priv)
581 {
582 if (!dev_priv->ldu_priv)
583 return -ENOSYS;
584
585 BUG_ON(!list_empty(&dev_priv->ldu_priv->active));
586
587 kfree(dev_priv->ldu_priv);
588
589 return 0;
590 }
591
592
vmw_kms_ldu_do_bo_dirty(struct vmw_private * dev_priv,struct vmw_framebuffer * framebuffer,unsigned int flags,unsigned int color,struct drm_mode_rect * clips,unsigned int num_clips)593 static int vmw_kms_ldu_do_bo_dirty(struct vmw_private *dev_priv,
594 struct vmw_framebuffer *framebuffer,
595 unsigned int flags, unsigned int color,
596 struct drm_mode_rect *clips,
597 unsigned int num_clips)
598 {
599 size_t fifo_size;
600 int i;
601
602 struct {
603 uint32_t header;
604 SVGAFifoCmdUpdate body;
605 } *cmd;
606
607 fifo_size = sizeof(*cmd) * num_clips;
608 cmd = VMW_CMD_RESERVE(dev_priv, fifo_size);
609 if (unlikely(cmd == NULL))
610 return -ENOMEM;
611
612 memset(cmd, 0, fifo_size);
613 for (i = 0; i < num_clips; i++, clips++) {
614 cmd[i].header = SVGA_CMD_UPDATE;
615 cmd[i].body.x = clips->x1;
616 cmd[i].body.y = clips->y1;
617 cmd[i].body.width = clips->x2 - clips->x1;
618 cmd[i].body.height = clips->y2 - clips->y1;
619 }
620
621 vmw_cmd_commit(dev_priv, fifo_size);
622 return 0;
623 }
624